fix(dashboard): nouveau bouton pour vérifier la cohérence des données et retélécharger si besoin #1681
+217
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudambro
had a problem deploying
to
review-auto
GitHub Actions
Error
arnaudambro
force-pushed
the
fix/check-data-consistency
branch
from
c237238 to
1579f14
Compare
arnaudambro
temporarily deployed
to
review-auto
GitHub Actions
Inactive
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
added 3 commits
October 2, 2023 17:25
… et retélécharger si besoin
arnaudambro
force-pushed
the
fix/check-data-consistency
branch
from
1579f14 to
798c150
Compare
arnaudambro
had a problem deploying
to
review-auto
GitHub Actions
Error
arnaudambro
temporarily deployed
to
review-auto
GitHub Actions
Inactive
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 Deployment for commit 54cb65c : IngressesDocker images
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
l'idée c'est de tester ce bouton critique en conditions réelles avec des gens de confiance avant de mettre en production pour tout le monde
Dans cette PR:
Quand on clique sur Option/Alt, le bouton "Rafraichir" devient "NOUVEAU RAFRAICHIR" qui consiste en
À l'avenir, si ce bouton fonctionne bien (à tester avec quelques organisations), on peut utiliser le comportement du bouton "NOUVEAU RAFRAICHIR" pour le bouton "Rafraichir"
NOTE 1: j'ai volontairement laissé les logs pour pouvoir tester, on peut les dégager avant de merger, ou après, c'est selon 😁
NOTE 2: ce commit 798c150 est intéressant peut-être: si on inverse l'ordre de
clearCacheetsetLastLoad(0)alors j'arrive à reproduire les "pertes de file active" et autres problèmes de cache corrompu. SInon, honnêtement, je n'ai jamais réussi a reproduire en local, et j'utilise trop peu en prod je pense...NOTE 3: je trouve que le
DataLoaderest difficile à appréhender, après quelques mois sans y toucher. À discuter peut-être